Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 10, 2025

Add "Go back" button to Stripe redirect error page and improve error handling

This PR enhances the Stripe redirect error page by adding a "Go back" button, allowing users to navigate away from error states. It also improves error handling in the billing checkout flow by:

  1. Converting getBillingCheckoutUrl() to return structured responses with proper error messages
  2. Adding specific error messages for different HTTP status codes (402 for outstanding invoices, 429 for rate limiting)
  3. Displaying these more descriptive error messages to users when checkout fails

These changes provide a better user experience when errors occur during the checkout process.

Summary by CodeRabbit

  • New Features

    • Added a "Go back" button to the Stripe redirect error page, allowing users to easily return to the previous screen.
  • Bug Fixes

    • Improved error handling during the checkout process, providing clearer error messages for issues such as authentication, outstanding invoices, rate limiting, and unknown errors. Error messages are now displayed directly on the error page when checkout fails.

PR-Codex overview

This PR focuses on enhancing error handling in the checkout process for Stripe payments. It updates functions to return structured error responses and modifies the UI to display errors more effectively.

Detailed summary

  • Changed getBillingCheckoutUrl to return structured error responses.
  • Updated the checkout page to handle errors based on the response status.
  • Modified StripeRedirectErrorPage to include a "Go back" button for user navigation.
  • Improved error logging for various HTTP status codes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 6:38pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 10, 2025 6:38pm
login ⬜️ Skipped (Inspect) Jun 10, 2025 6:38pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 10, 2025 6:38pm
wallet-ui ⬜️ Skipped (Inspect) Jun 10, 2025 6:38pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 June 10, 2025 17:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 10, 2025 17:17 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 10, 2025 17:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 10, 2025 17:17 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2025

⚠️ No Changeset found

Latest commit: eb1c705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 10, 2025

Walkthrough

The changes refactor the billing checkout flow in the dashboard app to use structured error handling. The getBillingCheckoutUrl function now returns a discriminated union object indicating success or specific error states. The checkout page and error page components are updated to handle and display these error messages and provide improved navigation.

Changes

File(s) Change Summary
.../stripe/_components/StripeRedirectErrorPage.tsx Added "use client" directive, imported Button and useDashboardRouter, added "Go back" button for navigation.
.../stripe/checkout/[team_slug]/[sku]/page.tsx Updated to handle structured response from getBillingCheckoutUrl; displays error messages based on status.
.../stripe/utils/billing.ts Refactored getBillingCheckoutUrl to return a discriminated union object with status and error messages.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CheckoutPage
    participant BillingUtils
    participant StripeRedirectErrorPage

    User->>CheckoutPage: Access checkout page
    CheckoutPage->>BillingUtils: getBillingCheckoutUrl({ teamSlug, sku })
    BillingUtils-->>CheckoutPage: { status: "success", data: url } or { status: "error", error: message }
    alt Success
        CheckoutPage->>User: Redirect to billing checkout URL
    else Error
        CheckoutPage->>StripeRedirectErrorPage: Render with error message
        StripeRedirectErrorPage->>User: Show error and "Go back" button
        User->>StripeRedirectErrorPage: Click "Go back"
        StripeRedirectErrorPage->>CheckoutPage: router.back()
    end
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 604612d and eb1c705.

📒 Files selected for processing (3)
  • apps/dashboard/src/app/(app)/(stripe)/_components/StripeRedirectErrorPage.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/(stripe)/checkout/[team_slug]/[sku]/page.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/(stripe)/utils/billing.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/(app)/(stripe)/_components/StripeRedirectErrorPage.tsx
  • apps/dashboard/src/app/(app)/(stripe)/checkout/[team_slug]/[sku]/page.tsx
  • apps/dashboard/src/app/(app)/(stripe)/utils/billing.ts
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 10, 2025
Copy link
Member Author

jnsdls commented Jun 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls force-pushed the _Dashboard_Improve_error_handling_in_billing_checkout_process branch from e028770 to 604612d Compare June 10, 2025 17:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 10, 2025 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 10, 2025 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 10, 2025 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 10, 2025 17:19 Inactive
@jnsdls jnsdls marked this pull request as ready for review June 10, 2025 17:19
@jnsdls jnsdls requested review from a team as code owners June 10, 2025 17:19
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (9643b8d) to head (eb1c705).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7318   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         909      909           
  Lines       58673    58673           
  Branches     4158     4158           
=======================================
  Hits        32607    32607           
  Misses      25959    25959           
  Partials      107      107           
Flag Coverage Δ
packages 55.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 298 ms (+83.8% 🔺) 1.6 s
thirdweb (cjs) 345.55 KB (0%) 7 s (0%) 1.3 s (+7.42% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 79 ms (+537.57% 🔺) 193 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 41 ms (+1030.38% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 96 ms (+250.62% 🔺) 487 ms

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 14, 2025
You have used $0.00 of your $100.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 10, 2025

Merge activity

# Add "Go back" button to Stripe redirect error page and improve error handling

This PR enhances the Stripe redirect error page by adding a "Go back" button, allowing users to navigate away from error states. It also improves error handling in the billing checkout flow by:

1. Converting `getBillingCheckoutUrl()` to return structured responses with proper error messages
2. Adding specific error messages for different HTTP status codes (402 for outstanding invoices, 429 for rate limiting)
3. Displaying these more descriptive error messages to users when checkout fails

These changes provide a better user experience when errors occur during the checkout process.

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **New Features**
  - Added a "Go back" button to the Stripe redirect error page, allowing users to easily return to the previous screen.

- **Bug Fixes**
  - Improved error handling during the checkout process, providing clearer error messages for issues such as authentication, outstanding invoices, rate limiting, and unknown errors. Error messages are now displayed directly on the error page when checkout fails.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the _Dashboard_Improve_error_handling_in_billing_checkout_process branch from 604612d to eb1c705 Compare June 10, 2025 18:30
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 10, 2025 18:30 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 10, 2025 18:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 10, 2025 18:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 10, 2025 18:30 Inactive
@graphite-app graphite-app bot merged commit eb1c705 into main Jun 10, 2025
24 checks passed
@graphite-app graphite-app bot deleted the _Dashboard_Improve_error_handling_in_billing_checkout_process branch June 10, 2025 18:39
@vercel vercel bot temporarily deployed to Production – thirdweb_playground June 10, 2025 18:39 Inactive
@vercel vercel bot temporarily deployed to Production – login June 10, 2025 18:39 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui June 10, 2025 18:39 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 June 10, 2025 18:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants